Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Freight events reader test AND adaptions/fixes on carrierFreightXXXEventHandlers #2876

Merged
merged 24 commits into from
Oct 20, 2023

Conversation

nixlaos
Copy link
Collaborator

@nixlaos nixlaos commented Oct 16, 2023

added tests for and CarrierEventsReaders. This closes #2771.

@nixlaos nixlaos requested a review from kt86 October 16, 2023 10:01
@kt86 kt86 marked this pull request as draft October 19, 2023 12:49
@kt86 kt86 self-assigned this Oct 19, 2023
@kt86
Copy link
Contributor

kt86 commented Oct 19, 2023

This PR will also include the following fixes:

  • renaming of freight * EventHandler to carrier * EventHandler
  • add two missing EventHandlers: pickup and dropoff events both have two (and not only one) event: start and end
  • Error in convert method in CarrierShipmentDelivery * Event

I also updated the test input files and added tests, that will count the number of carrier related events.

In a next step, I will also check the events itself – at least one per type.

@kt86 kt86 removed their request for review October 20, 2023 14:09
@kt86 kt86 marked this pull request as ready for review October 20, 2023 14:10
@kt86 kt86 changed the title Freight events reader test Freight events reader test AND adaptions/fixes on carrierFreightXXXEventHandlers Oct 20, 2023
@kt86 kt86 merged commit 8e64186 into master Oct 20, 2023
48 checks passed
@kt86 kt86 deleted the freight_eventsReaderTest branch October 20, 2023 14:47
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Freight / Carriers: Add tests for EventsReader
2 participants